Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: support Jest 29 #494

Merged
merged 7 commits into from
Aug 30, 2022
Merged

breaking: support Jest 29 #494

merged 7 commits into from
Aug 30, 2022

Conversation

nogic1008
Copy link
Collaborator

@nogic1008 nogic1008 commented Aug 29, 2022

⚠️Breaking Changes

  • Need Jest 29
    • Node.js 12 and 17 are no longer supported.

Code Changes

Update Jest packages

  • babel-jest: 29.x
  • jest: 29.x
  • jest-environment-jsdom: 29.x
  • ts-jest: 29.0.0-next.0

Fix Test errors

  • Update test snapshot for v29
  • Use relative paths on source map test
  • Use os.tmpdir() to resolve test failures on Windows

CI workflow updates

  • Change version matrix to Node.js 14, 16, 18
  • Use actions/setup-node@v3 and built-in cache feature

Other

  • Dedupe project packages

See also

@nogic1008 nogic1008 added enhancement upstream Due to other packages (like Jest) labels Aug 29, 2022
@nogic1008 nogic1008 requested a review from lmiller1990 August 29, 2022 00:27
@nogic1008 nogic1008 self-assigned this Aug 29, 2022
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's ship a 29.x version.

@lmiller1990 lmiller1990 merged commit 1cd403d into vuejs:master Aug 30, 2022
@nogic1008 nogic1008 deleted the jest-29 branch August 30, 2022 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement upstream Due to other packages (like Jest)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants