Fix source maps for vue2-jest #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
approved these changes
Aug 3, 2022
|
CI is failing - can you take a look? |
|
@lmiller1990 I've fixed the test issues, it was a path mismatch between my machine and the github CI agent. Can you pls re-run the CI? I don't have the permissions to do so. |
|
@NikhilVerma @lmiller1990 im using vue2-jest but not using typescript, im also having source map issues. Wondering will this fix it for ?.. |
|
Looks good, I'll leave this open until I've got bandwidth to release, that should be in the next few days. Ping me if it does not happen. @john-maddock no idea, you could test it out by just copy pasting the changes into your node_modules/vue-jest directory - no need to compile, it's regular JS. |
|
Let's wait for #483 to merge, then I'll merge this and release the new version. |
|
Let's just ship this. |
pmrotule
added a commit
to pmrotule/vue-jest
that referenced
this pull request
Aug 7, 2023
pmrotule
added a commit
to onrunning/vue-jest
that referenced
this pull request
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been borrowed from vue3-jest
For me this fixes: #474