Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jest 28 #468

Merged
merged 5 commits into from
May 17, 2022
Merged

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Apr 27, 2022

fixes #467

[BREAKING CHANGE]:

  • Drop support for Jest 27
  • Drop support for Node 10 (Drop Node 10 support as Jest 28 dropped it as well)
  • Drop support for Typescript < 4.3 (Jest 28 requires Typescript >= 4.3)

@lmiller1990
Copy link
Member

Nice job, I'll take a look at this soon.

Valentin Palkovič added 4 commits May 6, 2022 08:50
fixes vuejs#467

[BREAKING CHANGE]: Drop support for jest 27
Jest 28 dropped Node 10 support as well
Copy link
Collaborator

@nogic1008 nogic1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code fixes is LGTM, but docs need to update for clarify versioning.

README.md Outdated Show resolved Hide resolved
@nogic1008 nogic1008 added vue3-jest Vue 3 upstream Due to other packages (like Jest) vue2-jest Vue 2 labels May 9, 2022
@lmiller1990
Copy link
Member

Once the docs is updated we can merge and release the Jest 28 support. 🙏

@lmiller1990
Copy link
Member

Nice job @valentinpalkovic. Please give me a day or two to get this merged and released, since we need to also create the legacy 27.x branch before merging, and a few other things. I'm glad supporting Jest 28 was quite straight forward.

@ScottAwesome
Copy link

@lmiller1990 any chance of landing this in the next few days?

@lmiller1990
Copy link
Member

I will probably be busy until the weekend, so it should be done by the start of next week.

@lmiller1990
Copy link
Member

I will do this right now.

@lmiller1990 lmiller1990 merged commit d8568cb into vuejs:master May 17, 2022
@lmiller1990
Copy link
Member

It's out, please give it a try: https://github.com/vuejs/vue-jest/releases/tag/v28.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Due to other packages (like Jest) vue2-jest Vue 2 vue3-jest Vue 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support jest 28
4 participants