Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #417: Should not return empty string so that it is compatible w… #428

Merged
merged 2 commits into from
May 2, 2022

Conversation

lptai
Copy link
Contributor

@lptai lptai commented Dec 14, 2021

Fix issue mentioned here #417

@lmiller1990
Copy link
Member

Can you try merging in the latest master? Sorry for the slow response.

@Magiczne
Copy link

@lptai will you update this PR? If not i will go and create a fresh one based on the current master, cause that bug is holding me in my projects

@lptai
Copy link
Contributor Author

lptai commented Apr 26, 2022

Doing it now @Magiczne

@lptai
Copy link
Contributor Author

lptai commented Apr 26, 2022

Can you try merging in the latest master? Sorry for the slow response.

updated to latest master @lmiller1990

@lmiller1990
Copy link
Member

Will review soon, thanks.

@lmiller1990 lmiller1990 merged commit e2c7a56 into vuejs:master May 2, 2022
@lmiller1990
Copy link
Member

It's released. https://github.com/vuejs/vue-jest/releases/tag/v28.0.0

You might need to update to Jest 28 to get this; I don't think it got in the last release for v27. If this is big problem, let me know, but updating to the latest Jest is always a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants