-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PostCSS mixins cause style parsing to break #425
Conversation
Replaced `extract-from-css` which is outdated (7yo) with `css-tree` Resolves #424
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great, thanks for your work @sevilyilmaz !
@lmiller1990 OK with you?
@lmiller1990 could you have a look at this? The issue is a blocker for me. |
@cexbrayat, @lmiller1990, are there any blockers prevent this PR to be merged? |
No problem, just a lack of resources and time. Do you know what the CI build is failing? |
I see. The jobs have been failing in the previous commits as well in the |
Yeah it's because we dropped CircleCI @lmiller1990 (see #413 where I mentioned I did not have the access to remove this build) You can safely ignore it 👍 |
Ok, gotta do a release soon. I REALLY want semantic release set up at some point, I'm starting to become the bottleneck. |
Do you have any plans for this change to be released soon? |
I will do it by the end of the week. Ping me if it isn't out by then. I am not working on |
Hi @lmiller1990, friendly reminder, this change is not released yet. I would love to contribute for the semantic release but these days I don't have bandwidth for that. |
I tried to release this just now but CI failed https://github.com/vuejs/vue-jest/actions/workflows/node.yml I am not sure what's going on, I'll look into it. |
If you can fix CI before I do, we can release v27. I'm sorry I haven't been able to do this - I do not use Vue Jest, it's hard to prfioritize this. We really need an active maintainer, but seems no-one is super keen on doing so right now. |
I released v27.0.0. https://github.com/vuejs/vue-jest/releases/tag/v27.0.0 I hope your issue is resolved now! If not, please open an issue and/or post a PR. |
Yes, it solved my issue. Thank you for taking time to release the package. |
Replaced
extract-from-css
which is outdated (7yo) withcss-tree
.Resolves #424