Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PostCSS mixins cause style parsing to break #425

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix: PostCSS mixins cause style parsing to break #425

merged 1 commit into from
Feb 17, 2022

Conversation

sevilyilmaz
Copy link
Contributor

Replaced extract-from-css which is outdated (7yo) with css-tree.

Resolves #424

Replaced `extract-from-css` which is outdated (7yo) with `css-tree`

Resolves #424
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great, thanks for your work @sevilyilmaz !

@lmiller1990 OK with you?

@cexbrayat cexbrayat requested a review from lmiller1990 December 8, 2021 07:42
@sevilyilmaz
Copy link
Contributor Author

@lmiller1990 could you have a look at this? The issue is a blocker for me.

@sevilyilmaz
Copy link
Contributor Author

@cexbrayat, @lmiller1990, are there any blockers prevent this PR to be merged?

@lmiller1990
Copy link
Member

No problem, just a lack of resources and time. Do you know what the CI build is failing?

@sevilyilmaz
Copy link
Contributor Author

I see. The jobs have been failing in the previous commits as well in the master with the same message: "No configuration was found in your project.". It seems something related to the CircleCI config. It doesn't seem related to this PR.

@cexbrayat
Copy link
Member

Yeah it's because we dropped CircleCI @lmiller1990 (see #413 where I mentioned I did not have the access to remove this build)

You can safely ignore it 👍

@lmiller1990
Copy link
Member

Ok, gotta do a release soon. I REALLY want semantic release set up at some point, I'm starting to become the bottleneck.

@lmiller1990 lmiller1990 merged commit 4c8f675 into vuejs:master Feb 17, 2022
@sevilyilmaz
Copy link
Contributor Author

Do you have any plans for this change to be released soon?

@lmiller1990
Copy link
Member

lmiller1990 commented Apr 4, 2022

I will do it by the end of the week. Ping me if it isn't out by then.

I am not working on vue-jest much lately, it definitely needs some support, thus sllow releases. If anyone is reading and would like to make a PR adding semantic release support and speed things up, that'd be great.

@sevilyilmaz
Copy link
Contributor Author

Hi @lmiller1990, friendly reminder, this change is not released yet.

I would love to contribute for the semantic release but these days I don't have bandwidth for that.

@lmiller1990
Copy link
Member

I tried to release this just now but CI failed https://github.com/vuejs/vue-jest/actions/workflows/node.yml

I am not sure what's going on, I'll look into it.

@lmiller1990
Copy link
Member

If you can fix CI before I do, we can release v27. I'm sorry I haven't been able to do this - I do not use Vue Jest, it's hard to prfioritize this.

We really need an active maintainer, but seems no-one is super keen on doing so right now.

@lmiller1990
Copy link
Member

I released v27.0.0. https://github.com/vuejs/vue-jest/releases/tag/v27.0.0

I hope your issue is resolved now! If not, please open an issue and/or post a PR.

@sevilyilmaz
Copy link
Contributor Author

Yes, it solved my issue. Thank you for taking time to release the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using PostCSS mixins in CSS modules causes a syntax error
3 participants