Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit vue-sfc dependency #410

Closed
wants to merge 1 commit into from

Conversation

Theiaz
Copy link

@Theiaz Theiaz commented Nov 15, 2021

It is delivered with Vue by default.

For more information see Issue

@Theiaz Theiaz changed the title Remove explicit vue-sfc depdency Remove explicit vue-sfc dependency Nov 15, 2021
cexbrayat added a commit to cexbrayat/vue-jest that referenced this pull request Nov 18, 2021
Note that this also removes the now unneeded `@vue/compiler-sfc` dependency.
Fixes vuejs#410
@cexbrayat
Copy link
Member

cexbrayat commented Nov 18, 2021

I accidentally did the same work in #411 as I needed to update vue3-jest to a more recent Vue version.

I'll close this one, as it needed to be removed in a few extra places (in particular in the Yarn lockfile).
Thanks for the issue and PR!

@cexbrayat cexbrayat closed this Nov 18, 2021
lmiller1990 pushed a commit that referenced this pull request Nov 28, 2021
Note that this also removes the now unneeded `@vue/compiler-sfc` dependency.
Fixes #410
lmiller1990 pushed a commit that referenced this pull request Nov 28, 2021
* chore: update to vue v3.2.22

Note that this also removes the now unneeded `@vue/compiler-sfc` dependency.
Fixes #410

* feat: allow to pass compilerOptions via the Jest config for Vue 3

These options can be used to define Vue compiler options in `@vue/vue3-jest`.

For example, to enable the newly intrioduced `propsDestructureTransform` in Vue v3.2.20:

```js
globals: {
  'vue-jest': {
    compilerOptions: {
      propsDestructureTransform: true
    }
  }
}
```

or to disable `refTransform` (which is enabled by default):

```js
globals: {
  'vue-jest': {
    compilerOptions: {
      refTransform: false
    }
  }
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants