Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compilerOptions to vue-jest global options #380

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

SasanFarrokh
Copy link
Contributor

@SasanFarrokh SasanFarrokh commented Sep 3, 2021

This PR allows to pass down compilerOptions to vue-jest transformation.

@SasanFarrokh
Copy link
Contributor Author

Could you review this? @cexbrayat

@lmiller1990
Copy link
Member

Seems fine to me!

@lmiller1990
Copy link
Member

What is your use-case, btw?

@lmiller1990 lmiller1990 self-requested a review September 6, 2021 00:41
@lmiller1990 lmiller1990 merged commit e6520f7 into vuejs:master Sep 6, 2021
@cexbrayat
Copy link
Member

Lachlan already merged, but I'm also curious about the use case.

And I think adding a test would be great, so we can remember why this is there, and not have a regression.

@SasanFarrokh
Copy link
Contributor Author

@lmiller1990 @cexbrayat Hey, Thanks for merging.
About the use case, we're using custom directives and other custom node transformations. Just to mention, one of them is v-test directive that transforms to data-test in test environments (in production mode it does nothing).
So we needed to pass the compiler options down to vue-jest.
I thought it would be a good option to be able to customize the whole compilerOptions.

@cexbrayat
Copy link
Member

@SasanFarrokh Sounds cool 👍

Would you mind opening a PR with a small test for this use case? It can be a simple one, just to make sure we don't have a regression later.

@lmiller1990
Copy link
Member

A test would be great.

@SasanFarrokh
Copy link
Contributor Author

A Simple test added, just to ensure compilerOptions had been used.
#385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants