-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: migrate to monorepo (for vue-jest@5) #361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments.
I have a question that we did not think about. We will need to support multiple versions of Jest at the same time for a while - in this case, we need to maintain v26 and v27 support.
Should we have two packages? vue3-jest26
and vue3-jest27
? What do you think is the best way to handle this?
packages/vue3-jest/package.json
Outdated
"peerDependencies": { | ||
"@babel/core": "7.x", | ||
"babel-jest": ">= 24 < 27", | ||
"jest": ">= 24 < 27 ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should only support Jest 26 now, right, since we specify "version":" "26.0.0"`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to 26.x
.
@lmiller1990
|
@nogic1008 I see. I wonder if there will be any complexity in having both Vue 2 and Vue 3 in the same monorepo? Are we able to do this (I guess we need to do Is there anything else you'd like to do before merging this? Otherwise, I'll merge and do a release to make sure everything is 👌 . Then we can work on getting Jest 27 support merged. |
I believe that the complexity of including different Vue version in We need to merge |
Ok, let's try your idea. I think we can update the README later, next goal should be Jest 27. So we won't need |
It breaks package.json histories.
This PR is a part of #355.
Similar to #360, but targeted at
next
(vue-jest@5) branch.Changes
e2e/__projects__/*
projects toe2e/3.x/*
package.json
andlib/
topackages/vue3-jest/
[email protected]