Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support ESLint 7.x #71

Closed
wants to merge 9 commits into from
Closed

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented May 8, 2020

ESLint v7.0.0 is released 🎉

(dev)Dependencies should be compatible with ESLint 7 too before we can merge this one:


Closes #70

BREAKING CHANGE: Requires Node@^10.12.x || 12.x
@mysticatea
Copy link
Member

Thank you for your contribution.

I have a question, why is the breaking change needed to support ESLint 7?

@mysticatea
Copy link
Member

I know it because l have made that change. But, that is not requirements for custom parsers.

@MichaelDeBoey
Copy link
Contributor Author

Then we would probably fix the test in some way, no? 🤔

@mysticatea
Copy link
Member

Yes. We should not need breaking changes. Let's just confirm the parser works well on ESLint 7.

@MichaelDeBoey
Copy link
Contributor Author

Hmmm really weird that CI keeps failing when I updated the tests 🤔🧐
Can't figure out what's causing the fails though.

@mysticatea
Copy link
Member

mysticatea commented May 13, 2020

I merged this along with some tweaks: 2df66e4

  • Update git submodule /test/fixtures/eslint to ESLint 7
  • Handle new syntax errors of the new minor version of acorn
  • Convert bash script in CI to Node.js script for Windows job

Thank you.

@mysticatea mysticatea closed this May 13, 2020
@MichaelDeBoey MichaelDeBoey deleted the eslint-7 branch May 13, 2020 21:29
@MichaelDeBoey
Copy link
Contributor Author

@mysticatea Any idea when this will be released? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 7.x
2 participants