-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support ESLint 7.x #71
Conversation
BREAKING CHANGE: Requires Node@^10.12.x || 12.x
Thank you for your contribution. I have a question, why is the breaking change needed to support ESLint 7? |
@mysticatea ESLint 7 only supports Node@^10.12.x || >=12.x |
I know it because l have made that change. But, that is not requirements for custom parsers. |
Then we would probably fix the test in some way, no? 🤔 |
Yes. We should not need breaking changes. Let's just confirm the parser works well on ESLint 7. |
Hmmm really weird that CI keeps failing when I updated the tests 🤔🧐 |
I merged this along with some tweaks: 2df66e4
Thank you. |
@mysticatea Any idea when this will be released? 🤔 |
ESLint v7.0.0 is released 🎉
(dev)Dependencies should be compatible with ESLint 7 too before we can merge this one:
@mysticatea/eslint-plugin
(Support ESLint 7.x mysticatea/eslint-plugin#28)Closes #70