Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: normalize source map file path on windows #83

Merged
merged 2 commits into from
Feb 1, 2019
Merged

fix: normalize source map file path on windows #83

merged 2 commits into from
Feb 1, 2019

Conversation

3cp
Copy link
Contributor

@3cp 3cp commented Jan 31, 2019

The fixes for TypeScript errors are in separated commit.

Updated test snapshot file.

  1. Sources paths was cleaned up by upgrading component-compiler-utils.
  2. Styles mapping changes are due to newer version of postcss (from component-compiler-utils).
  3. postcss rawResult is removed.
  • The rawResult contains ast tree which postcss always prepends current working directory to referencing file name.
  • This is a main pain point of maintaining this snapshot test.
  • The correctness of rawResult is responsibility of postcss, not vue compiler. So it's irrelevant to test it here.

This is a companion PR for vuejs/component-compiler-utils#51

3cp added 2 commits February 1, 2019 09:22
Took the opportunity to update TS to latest version, cleanup all type errors.
Updated test snapshot file.
1. Sources paths was cleaned up by upgrading component-compiler-utils.
2. Styles mapping changes are due to newer version of postcss (from component-compiler-utils).
3. postcss rawResult is removed.
 * The rawResult contains ast tree which postcss always prepends current working directory to referencing file name.
 * This is a main pain point of maintaining this snapshot test.
 * The correctness of rawResult is responsibility of postcss, not vue compiler. So it's irrelevant to test it here.

This is a companion PR for vuejs/component-compiler-utils#51
@znck znck merged commit c4bcd40 into vuejs:master Feb 1, 2019
@3cp 3cp deleted the fix-source-map-path-separator branch February 4, 2019 23:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants