-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor the ipc module. #7076
base: dev
Are you sure you want to change the base?
Conversation
Local is passed. let me see.:sweat_smile: |
Their versions are fixed, npm does not allow overwriting existing versions, so no risk.
We don't need new features, either. As long as there are no vulnerabilities we are fine. |
Hi, Is there an estimate on when this change will be released?
If it's going to be a while away I can create a PR to update the dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern with this PR is that it makes CLI UI not able to communicate with projects running older versions of @vue/cli-service
via IPC.
Is there anyway to keep that compatibility?
To be compatible with older versions of @vue/cli-service, we can use the same |
It can be compatible with older versions after using the same ipc path and message format. I have tested it on the |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
The dependencies of @achrinza/node-ipc has security risks.The owner of js-message and easy-stack remainsBrandon Nozaki Miller
.@achrinza/node-ipc
does not accept new features.