Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-service): don't write entry-wc to node_modules #6101

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Nov 30, 2020

Fixes yarnpkg/berry#2189
Ref yarnpkg/berry#964
Ref #5135

When building web components (--target wc) @vue/cli-service tries to write an entry-wc.js file to itself which breaks when running multiple builds in parallel or when using Yarn PnP.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@merceyz merceyz force-pushed the merceyz/pnp-web-components branch from 19a8def to cfaa9bc Compare November 30, 2020 13:17
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!

@haoqunjiang haoqunjiang merged commit f685044 into vuejs:dev Dec 2, 2020
@merceyz merceyz deleted the merceyz/pnp-web-components branch December 2, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to build web-component in pnp mode.
2 participants