-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace eslint-loader by eslint-webpack-plugin #6094
Conversation
|
1e2f8db
to
f67bc93
Compare
After bumping the version of |
Although eslint-webpack-plugin disable 'threads' by default, it's better set it explicitly
fix yarn.lock conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Hi @sodatea @fangbinwei , this fix doesn't seem to be in the latest release for vue-cli-eslint (4.5.15) which was released 3 months ago. If i want this fix, is it safe to use 5.0.0-rc2? |
Yes, I think so. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
close #5926, using
eslint-webpack-plugin
can fix the problem ofeslint-loader
caused bycache-loader
, related issue: #3065, #5399, #4425eslint@7 contains a break change related to plugin resolution
After checking the rfc, I believe new behavior is reasonable and it does not conflict with the current project. So I didn't set
resolvePluginsRelativeTo
likecreate-react-app
TODO
eslint-webpack-plugin
after this important pr ofeslint-webpack-plugin
is mergedeslint-webpack-plugin
optionthreads
(defaulttrue
now) may cause performance problem, related issue. maybe setthreads
tofalse
.