Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint-stage config is defined in package.json even if we choose to keep configurations in standalone files #6298

Closed
wujekbogdan opened this issue Feb 20, 2021 · 1 comment · Fixed by #6303
Closed

lint-stage config is defined in package.json even if we choose to keep configurations in standalone files #6298

wujekbogdan opened this issue Feb 20, 2021 · 1 comment · Fixed by #6303
Labels
contribution welcome intend to implement The team has the intention to implement this feature at some point. Contribution is also welcome.

Comments

@wujekbogdan
Copy link

Version

4.5.11

Environment info

  System:
    OS: macOS 10.15.7
    CPU: (8) x64 Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz
  Binaries:
    Node: 12.13.1 - ~/.nodebrew/current/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 6.14.5 - ~/.nodebrew/current/bin/npm
  Browsers:
    Chrome: 88.0.4324.182
    Edge: Not Found
    Firefox: 83.0
    Safari: 14.0
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce

  1. Run vue create myProject
  2. Follow the wizard
  3. On the "Where do you prefer placing config for Babel, ESLint, etc.?" step choose "In dedicated config files"

What is expected?

lint-staged config do be stored in .lintstagedrc.yml or .lintstagedrc

What is actually happening?

lint-staged config is stored in package.json
@haoqunjiang haoqunjiang added contribution welcome intend to implement The team has the intention to implement this feature at some point. Contribution is also welcome. labels Feb 20, 2021
HexPandaa added a commit to HexPandaa/vue-cli that referenced this issue Feb 21, 2021
@HexPandaa
fix(create): write the lint-staged config to its own file (close vuej…
08d9db7 
…s#6298)
@HexPandaa HexPandaa mentioned this issue Feb 21, 2021
Merged
9 tasks
@HexPandaa
Copy link
Contributor

Seems like it was quite an easy fix.

haoqunjiang pushed a commit that referenced this issue Feb 22, 2021
@HexPandaa
fix(create): write the lint-staged config to its own file (#6303)
c604182 
Closes #6298
This was referenced Mar 9, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome intend to implement The team has the intention to implement this feature at some point. Contribution is also welcome.
Projects
None yet
Milestone
No milestone
3 participants
@wujekbogdan @haoqunjiang @HexPandaa