-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo: wrong translation in markdown.md #4379
Conversation
I'm not a Chinese speaker, but the English version of that comment is "image lazy loading is disabled by default", and the Chinese should be something like "默认情况下,图片懒加载功能是禁用的" 👀 |
i'm not very sure, but in my opinion, in context, this comment should be "image lazy loading is enabled by default" |
Maybe it would be better to change it to"now enable lazy loading in markdown by default"? |
Ah, we want to tell that lazy loading is disabled by default but you can enable it for all images by setting /cc @awxiaoxian2020 |
export default {
markdown: {
image: {
// 默认情况下在 markdown 中默认禁用图片懒加载(即该配置默认为 false)
// 若想要在 markdown 中将默认启用图片懒加载,应将其设置为 true 。
lazyLoading: true
}
}
} maybe better? |
Hi, @brc-dd He means if the comment is "image lazy loading is disabled by default", the code should be export default {
markdown: {
image: {
// image lazy loading is disabled by default
lazyLoading: false
}
} @MC-XiaoHei this comment I think it doesn't describe the code while just tell us why we need |
For me personally, this is a bit ambiguous, and if you think this is correct, you can close this PR |
Would something like this work - "默认禁用;设置为 true 可为所有图片启用懒加载。" |
Description
in Chinese ver of markdown.md, there is an translation error
Linked Issues
no
Additional Context
nothing