Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bsky social icon and website icon #4076

Closed
wants to merge 1 commit into from

Conversation

cyyynthia
Copy link

@cyyynthia cyyynthia commented Jul 25, 2024

Description

This PR adds an icon for Bluesky in social icons, and also adds a generic website icon for cases where people may want to link to their own website.

Linked Issues

No issue opened about this.

Additional Context

I'm opening this as a draft, as I noticed a comment in #3809 mentioning that adding new icons is currently not being considered due to lack of treeshaking.

Semi-unrelated remark, but I'm the maintainer of a Vite svg plugin that can create svg sprites out of imports (svgr but the right way haha); it doesn't have treeshaking yet but it's something I've been wanting to add for quite some time - maybe this or another approach can be used to make it possible to add new icons without bloating the build (or even let people go crazy and use the entire collection of simple-icons - after all if it's treeshaken why put limits! :p)

@github-actions github-actions bot added the stale label Sep 1, 2024
@brc-dd brc-dd closed this in #4339 Nov 4, 2024
@cyyynthia cyyynthia deleted the feat/bsky branch November 4, 2024 17:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant