Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: separate logo for dark mode #1006

Closed
4 tasks done
mesqueeb opened this issue Jul 17, 2022 · 2 comments · Fixed by #1155
Closed
4 tasks done

docs: separate logo for dark mode #1006

mesqueeb opened this issue Jul 17, 2022 · 2 comments · Fixed by #1155
Labels
docs Improvements or additions to documentation

Comments

@mesqueeb
Copy link
Contributor

Is your feature request related to a problem? Please describe.

My logo is a wordmark, so it includes text (in a dark color).

For dark mode this should be a lighter color (eg. white).

Currently the logo is added as svg, but Vitepress uses the image tag, so I can't even overwrite the colors via CSS.

Describe the solution you'd like

either include the logo as inline SVG or allow us to set a dark mode separate logo.

Describe alternatives you've considered

No response

Additional context

No response

Validations

@brc-dd
Copy link
Member

brc-dd commented Jul 17, 2022

Hi! its already supported. Refer this: #745 (comment). Though we haven't added it to docs yet.

@brc-dd brc-dd added the docs Improvements or additions to documentation label Jul 17, 2022
@mesqueeb
Copy link
Contributor Author

@brc-dd Great! thanks so much.

@mesqueeb mesqueeb changed the title separate logo for dark mode docs: separate logo for dark mode Jul 17, 2022
rijkvanzanten added a commit to rijkvanzanten/vitepress that referenced this issue Aug 10, 2022
vuejs#745 added support for a light vs dark mode logo, but according to vuejs#1006 (comment) was never documented. 

I figured a tweak to the docs would be a good first contribution to the project 🤩
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants