Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document changes in inject definition for feature vuejs/vue#6097 #1069

Merged
merged 4 commits into from
Mar 10, 2018
Merged

Document changes in inject definition for feature vuejs/vue#6097 #1069

merged 4 commits into from
Mar 10, 2018

Conversation

pdanpdan
Copy link
Contributor

@pdanpdan pdanpdan commented Aug 8, 2017

Allow defining optional inject dependency with default values (vuejs/vue#6322, vuejs/vue#6097).

…alues

Document changes in inject definition for feature #6097
@pdanpdan pdanpdan changed the title Document changes in inject definition for feature vue/#6097 Document changes in inject definition for feature vue#6097 Aug 8, 2017
@pdanpdan pdanpdan changed the title Document changes in inject definition for feature vue#6097 Document changes in inject definition for feature vuejs/vue#6097 Aug 8, 2017
@chrisvfritz
Copy link
Contributor

@pdanpdan I tweaked it slightly to make the options a little easier to read. Otherwise looks good! Let me know when that PR is merged and we'll merge this too. 🙂 👍

@pdanpdan
Copy link
Contributor Author

Sure, thank you.

@chrisvfritz
Copy link
Contributor

@pdanpdan I see that the PR is merged now. Are there any changes that need to be made here from a technical perspective?

@pdanpdan
Copy link
Contributor Author

pdanpdan commented Oct 7, 2017

No. This PR is still valid. I think it would apply from the next release.

@chrisvfritz
Copy link
Contributor

chrisvfritz commented Oct 7, 2017

Excellent. Then I'll just make a couple small content tweaks, so that it's ready when the next release comes along.

@sdras
Copy link
Member

sdras commented Mar 10, 2018

Hey all, this is a pretty old PR now, does anyone know the status of it?

@chrisvfritz chrisvfritz merged commit 32912bb into vuejs:master Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants