Skip to content

Commit

Permalink
feat(lib)!: disable skipLibCheck in library tsconfig, closes #5
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
This change requires libraries extending `tsconfig.lib.json` to be
type-checked against their dependencies as well as the `.d.ts`
files in their own projects. So it might introduce new type errors.

It bumps the Vue.js version requirement to `^3.4.0`, as the Vue.js core
can only be correctly type-checked in `--isolatedModules` mode after
version 3.4 (following the removal of `const enum` usage).

It might also increase the compilation time of the library projects.
  • Loading branch information
haoqunjiang committed Nov 28, 2024
1 parent ab39083 commit cee76cf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"peerDependencies": {
"typescript": "5.x",
"vue": "^3.3.0"
"vue": "^3.4.0"
},
"peerDependenciesMeta": {
"typescript": {
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.lib.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"compilerOptions": {
"noEmit": false,
"declaration": true,
"emitDeclarationOnly": true
"emitDeclarationOnly": true,
"skipLibCheck": false
}
}

0 comments on commit cee76cf

Please sign in to comment.