Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return abitility to use findComponent with DOM selector #994

Merged
merged 2 commits into from
Oct 7, 2021
Merged

fix: return abitility to use findComponent with DOM selector #994

merged 2 commits into from
Oct 7, 2021

Conversation

xanf
Copy link
Collaborator

@xanf xanf commented Oct 3, 2021

This PR consists of two commits:

Closes #904

@xanf xanf mentioned this pull request Oct 6, 2021
Closed
@lmiller1990 lmiller1990 self-requested a review October 7, 2021 00:55
lmiller1990
lmiller1990 approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@lmiller1990 lmiller1990 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like how little code you had to change to implement this.

Can release on the weekend.

@lmiller1990 lmiller1990 merged commit 239caf8 into master Oct 7, 2021
@lmiller1990 lmiller1990 deleted the xanf-reinstantiate-findcomponent-css branch October 7, 2021 00:58
@lmiller1990 lmiller1990 mentioned this pull request Nov 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmiller1990 lmiller1990 lmiller1990 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request to reinstate ability to use CSS selectors in findComponent
2 participants
@xanf @lmiller1990