chore(find): simplify vnode traversal #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
reviewed
Aug 10, 2021
| aggregateChildren(nodes, [node.component.subTree]) | ||
| } | ||
| if (node.suspense) { | ||
| // match children if component is Suspense | ||
| const { activeBranch } = node.suspense | ||
| aggregateChildren(nodes, [activeBranch]) | ||
| } | ||
| if (matches(node, selector) && !matchingNodes.includes(node)) { | ||
| if (matches(node, selector)) { |
lmiller1990
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
Great! I don't like how this is implemented in general - all the mutation is really confusing, I think we should really be using recursion here. Anyway, this is a good place to start simplifying things - we have lots of tests, so if someone does want to rework it for whatever reason, we can do so with confidence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, this is a proper finisher for #188 - we can avoid going over same vnodes again and again if we do not queue them multiple times - as long as we queue
node.component.subTree- no need to queuesubTree.children- they will be aggregated later by callingaggregateChildren(nodes, node.children)@lmiller1990 I think you will be happy to see we're finally simplifying this part a bit :)