chore(types): improve types of vueWrapper #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With more & more complexity in the code it would be great to utilize all powers of typescript.
While we can't get rid of all instances of
any(because this will cause a lot of different inconveniences for examples when you're usingprops()) - we should useunknown` when possible to indicate "all possible values" - this allows TypeScript to use all it's inference powerFor the same reason I've switched from overloads to using compound type for
selectorinfindComponent- withoutanyTypeScript performs better checks (and even caught that we were doing unneeded search when searcing by ref)