fix: missing types in release #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rc.11 is broken because the types are not included in the package. Using `git bisect` I found the culprit commit vuejs@85c2b1b The only change that has an impact is the addition of `type/compat.ts` which should have been named `types/compat.d.ts` I think. This commit applies the fix, and should hopefuly fix the packaging. Fixes vuejs#799
cexbrayat
force-pushed
the
fix/799-missing-types
branch
from
c51c34d to
1ed7987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rc.11 is broken because the types are not included in the package.
Using
git bisectI found the culprit commit 85c2b1bThe only change that has an impact is the addition of
type/compat.tswhich should have been namedtypes/compat.d.tsI think.This commit applies the fix, and should hopefully fix the packaging.
Fixes #799