Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(setData): do not concat previous and new array values #767

Merged
merged 1 commit into from
Jul 16, 2021
Merged

fix(setData): do not concat previous and new array values #767

merged 1 commit into from
Jul 16, 2021

Conversation

eunjae-lee
Copy link
Contributor

fixes #766

cexbrayat
cexbrayat approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR.

I'll wait for @afontcu review before merging, as maybe it was using concat for a purpose.

@cexbrayat cexbrayat requested a review from afontcu July 16, 2021 15:09
afontcu
afontcu approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@afontcu afontcu merged commit d337f92 into vuejs:master Jul 16, 2021
@eunjae-lee eunjae-lee deleted the fix/set-data branch July 16, 2021 15:36
@eunjae-lee eunjae-lee mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cexbrayat cexbrayat cexbrayat approved these changes

@afontcu afontcu afontcu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setData wrongly deep-merges
3 participants
@eunjae-lee @cexbrayat @afontcu