fix: opt-out of stubbing by passing false as stub #702
Conversation
| } | ||
| }) | ||
| expect(wrapper.html()).toEqual( | ||
| '<div class="ComponentWithChildren">\n' + |
There was a problem hiding this comment.
I wonder if we can use the inlineSnapshot feature from Jest here? Or do you think the string assertion is easier to read?
Thanks for all these PRs - let's do a release as soon as they are all merged up.
There was a problem hiding this comment.
I prefer to keep this as it is for now - just for consistency with style of other tests here. We could probably address it in separate clean-up MR
There was a problem hiding this comment.
A bit offtopic, regarding release. I believe I have some more (~5-10 MR coming) somewhere in next two days. I'm working (for fun) on building a prototype migration of gitlab-ui to Vue3 using compat build and it is surprisingly satisfying.
With new plugin system in play I was able to mimic a huge precent of old VTU v1 behavior in pretty clean manner (for now we would like to have tests which run on both versions of VTU and)
There was a problem hiding this comment.
Ok, happy to keep this as-is.
If you have 5-10 more PRs coming, we can wait until they are all merged up before doing a release.
There was a problem hiding this comment.
@lmiller1990 Sure, I'll drop a comment in "last PR" for letting you know. thank you for acting super-fast
@vue/test-utils 1 allowed to un-stub certain component by passing
falseas stub configurationRecover and document this behavior