fix: don't record native events that are included in emits option (#444) #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
added a commit
to cexbrayat/vue-test-utils-next
that referenced
this pull request
Apr 19, 2021
The fix introduced in vuejs#521 only account for emits define as an array, but it can also be define as an object. The latest rc.5 release breaks on components that use an object to define emits with: TypeError: emits.includes is not a function This commit fixes the unit test to have both cases check, and the relevant code to properly handle the object case.
lmiller1990
pushed a commit
that referenced
this pull request
Apr 19, 2021
The fix introduced in #521 only account for emits define as an array, but it can also be define as an object. The latest rc.5 release breaks on components that use an object to define emits with: TypeError: emits.includes is not a function This commit fixes the unit test to have both cases check, and the relevant code to properly handle the object case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #444
I experimented with attaching the native event listener to the component's parentElement, hoping that vue's native event emitting behaviour would provide what we really want to collect, but this broke a couple of other tests.
Instead I opted to simply filter out any native event names that appear in
emitswhile attaching our enumerated native event listeners. The added test passes and nothing else breaks so I think this should be adequate to fix #444.