Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow to use Teleport, Transition and TransitionGroup in PascalCase in stubs #2073

Merged
merged 3 commits into from
May 24, 2023
Merged

fix: allow to use Teleport, Transition and TransitionGroup in PascalCase in stubs #2073

merged 3 commits into from
May 24, 2023

Conversation

lbineau
Copy link
Contributor

@lbineau lbineau commented May 23, 2023

fixes #2072

  • fix: allow to use Teleport, Transition and TransitionGroup in PascalCase in stubs

@lbineau
fix: allow to use Teleport, Transition and TransitionGroup in PascalC…
e5069cf 
…ase in stubs

fix: allow to use Teleport, Transition and TransitionGroup in PascalCase in stubs
@netlify
Copy link

netlify bot commented May 23, 2023 •
edited
Loading

✅ Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 2167b2c
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/646ddfd3ccc94e0008c10e97
😎 Deploy Preview https://deploy-preview-2073--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cexbrayat
cexbrayat requested changes May 24, 2023
View reviewed changes
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes and we're good to merge 👍 Thanks!

tests/mountingOptions/global.stubs.spec.ts Outdated Show resolved Hide resolved
tests/mountingOptions/global.stubs.spec.ts Outdated Show resolved Hide resolved
tests/mountingOptions/global.stubs.spec.ts Outdated Show resolved Hide resolved
tests/mountingOptions/global.stubs.spec.ts Outdated Show resolved Hide resolved
@lbineau lbineau requested a review from cexbrayat May 24, 2023 09:34
@lbineau lbineau requested a review from cexbrayat May 24, 2023 10:01
cexbrayat
cexbrayat approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cexbrayat cexbrayat merged commit 5e34d41 into vuejs:main May 24, 2023
@lbineau lbineau deleted the fix/2072-pascal-case-stubs branch May 24, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cexbrayat cexbrayat cexbrayat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PascalCase not working for stubs config.global.stubs and Transition / TransitionGroup / Teleport
2 participants
@lbineau @cexbrayat