fix(stub): avoid stub cache for teleport for reactive update #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cexbrayat
approved these changes
May 18, 2023
| // Teleport/KeepAlive should return child nodes as a function | ||
| if (isTeleport(originalType) || isKeepAlive(originalType)) { | ||
| return [cachedTransformation, props, () => children, ...restVNodeArgs] | ||
| } |
There was a problem hiding this comment.
interesting that the workaround to get rid of the warnings is no longer needed 👍
There was a problem hiding this comment.
It's still needed a few lines below
lmiller1990
approved these changes
May 21, 2023
lmiller1990
reviewed
May 21, 2023
# Conflicts: # src/vnodeTransformers/util.ts
@lmiller1990 updated 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again an issue with the
transformationCache. I'm not quite sure yet why the cache is causing these issues.fix #2033
Also tested if #1781 is fixed aswell, but it wasn't the case