Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency typescript to v5 - autoclosed #2032

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 15, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
typescript (source) 4.9.5 -> 5.0.4 age adoption passing confidence

Release Notes

Microsoft/TypeScript

v5.0.4: TypeScript 5.0.4

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.0.3: TypeScript 5.0.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.0.2: TypeScript 5.0

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@netlify
Copy link

netlify bot commented Apr 15, 2023

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit d8cd3e0
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/645ccc0d04e13600080a56c4
😎 Deploy Preview https://deploy-preview-2032--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cexbrayat
Copy link
Member

@johnsoncodehk TS v5 is not type-checking correctly with the new signatures:

Error: src/createInstance.ts(106,5): error TS2322: Type 'DefineComponent<{}, {}, any>' is not assignable to type 'ConcreteComponent'.
  Type 'DefineComponent<{}, {}, any>' is not assignable to type 'FunctionalComponent<{}, any>'.
    Type 'ComponentPublicInstanceConstructor<any, any, any, any, ComputedOptions, MethodOptions> & ComponentOptionsBase<Readonly<ExtractPropTypes<...>>, ... 10 more ..., string> & VNodeProps & AllowedComponentProps & ComponentCustomProps' provides no match for the signature '(props: {}, ctx: Omit<{ attrs: Data; slots: Readonly<InternalSlots>; emit: ((event: unknown, ...args: any[]) => void) | ((event: string, ...args: any[]) => void); expose: (exposed?: Record<string, any>) => void; }, "expose">): any'.
Error: src/createInstance.ts(252,15): error TS2345: Argument of type 'DefineComponent<{}, {}, {}, {}, {}, ComponentOptionsMixin, ComponentOptionsMixin, {}, string, PublicProps, Readonly<ExtractPropTypes<{}>>, {}>' is not assignable to parameter of type 'ComponentOptions<{}, any, any, any, any, any, any, any>'.
  Type 'DefineComponent<{}, {}, {}, {}, {}, ComponentOptionsMixin, ComponentOptionsMixin, {}, string, PublicProps, Readonly<ExtractPropTypes<{}>>, {}>' is not assignable to type 'ComponentOptionsBase<{}, any, any, any, any, any, any, any, string, {}, {}, string>'.
    Types of property 'data' are incompatible.

Does that ring a bell?

@johnsoncodehk
Copy link
Member

I'm not sure yet, will take a look.

@renovate renovate bot force-pushed the renovate/typescript-5.x branch from 34c06fc to 9e8a29f Compare April 16, 2023 22:02
@johnsoncodehk
Copy link
Member

This seems to be reported correctly, TS 4.x would also show an error in the IDE, but tsc somehow fails to report the error, and TS 5.0 fixes the problem.

@renovate renovate bot force-pushed the renovate/typescript-5.x branch 2 times, most recently from 1feeef5 to c670f52 Compare May 1, 2023 04:46
@cexbrayat
Copy link
Member

@johnsoncodehk Do you know how we should fix it?

@renovate renovate bot force-pushed the renovate/typescript-5.x branch from c670f52 to fe74db8 Compare May 11, 2023 10:26
@cexbrayat
Copy link
Member

Nevermind think I found it #2047

(mixin had an incorrect type, and we were missing a few generic parameter in a signature)

@renovate renovate bot force-pushed the renovate/typescript-5.x branch from fe74db8 to d8cd3e0 Compare May 11, 2023 11:05
@renovate renovate bot changed the title chore(deps): update dependency typescript to v5 chore(deps): update dependency typescript to v5 - autoclosed May 11, 2023
@renovate renovate bot closed this May 11, 2023
@renovate renovate bot deleted the renovate/typescript-5.x branch May 11, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants