-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(fr): french documentation and README.md #1975
Conversation
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Ho wow Antoine, thanks! That's a lot of work. I'll review that in the next few days, and ping the rest of the team to check if everybody is OK with emerging this PR 👍 |
I have minor reservations about merging translations. VTU v1 had a ton of translations - they all get out of date almost immediately, as soon as the mainline docs change. I don't have a great solution to this problem. I also never consume docs in my non native language, so I don't know the value - is having some slightly out of date documentation in your native language more valuable than reading up to date ones in a non native language? Happy to let others make this decision - I'm not impacted, nor am I the target audience for this PR. 🙏 |
Hi @lmiller1990, thanks for taking a look at my PR. I totally understand you about the big work it is to maintain a doc in different languages. However, I think it has more pros than cons :
Cons :
Anyway, it's only my point of view and I'm totally OK if you don't want add it to the current load of work. |
My main concern is more about how we maintain. Eg, I think you (or another French speaker) should not need to make a PR each time. One idea I had was we link to your fork with the docs from the main repo's docs, so you can push a commit any time you like without requiring oversight. Just an idea. I am not against merging this here either. I will leave review/merging to you and @cexbrayat, I do not know French so I cannot really contribute. 🙏 |
@lmiller1990 could we at least add to the website the links to the translated versions? |
I think we can merge the entire translation - I was just voicing some of my concerns from the past, when had a ton of translations. I think @cexbrayat was going to do a quick review - I don't know any french. This looks like a lot of work that should be very useful for many people - can we just merge as-is @cexbrayat? |
If it's ok for you, I will resolve the conflicts and update the french docs with the latest changes. I'll ping you when it's done. |
👍 Thanks Antoine I did not have the time to review the docs, but I'll try to when you've updated them |
To integrate them, I think we need to check with the rest of the Vue team: there has been talks about it for other docs (router, pinia...), and I think there are some tools that we could leverage (ryo-chu for example) |
@cexbrayat, to be honest, I am already translating the pinia and vue router docs They are being served in these urls: vue-router-docs, pinia-docs |
I've already updated the first half of the docs (from |
While we figure out the strategy around translation with the rest of the Vue core libs, how about publishing to somewhere (netlify, GH pages) and linking to that from our English docs @antoinezanardi? |
It's ok for me. However, is it going to be temporary ? Do you want me to create another repository with a proper URL for GitHub Pages ? Something like |
8f8583e
to
6be9444
Compare
All of the french docs is now fixed and up to date with the latest changes. You can review it @cexbrayat . Thanks ! |
6be9444
to
870443f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably missed a ton of tiny things as it is quite big to review.
To be honest, some parts sound quite weird. Did you use Copilot or something like this to translate?
Thanks for your review ! I'll make the changes tomorrow. I translated most of the docs with ChatGPT (which is really great for that) and review all the texts after that to make it more "human" friendly. I could miss some weird parts, my bad ..! |
870443f
to
3aa53a8
Compare
@antoinezanardi, I believe ....
|
@nazarepiedady as I said in my previous comment, I reviewed all of the docs to be more readable for a human. Don't think I just put all the texts in a robot that gave me a translation and I pushed it as is in 20 min. It took me a considerable effort to change non sense sentences, fixed existing errors in original code examples or translated texts by myself when the use of chatGPT was not necessary. But, if you think I disrespect future French readers of this documentation (including myself, I translated it for my personal use, it's my native language), I would like to have your opinion of what I really produced here on this PR, not the way I did it. Please go ahead. |
@antoinezanardi I just share what I think about the usage of I am not saying to anyone what to do, only to let the comment |
@cexbrayat All the changes were applied, don't hesitate to give me your feedback about it |
Any update on this ? |
I'm going to go ahead and merge this up. 💯 |
For future ref, I think we should NOT have translations. This one can stay, though. I'd like to adopt the same stance as VueUse: https://vueuse.org/why-no-translations.html |
Hello all 👋 !
Here is the french version of the VTU documentation, including all vitepress pages, API and main README.
Details :
doc/
folder and vitepressconfig
:docs/.vitepress/config.ts
was partially rewritten to provide a better support for internationalization. To add another language, you just have to copy and paste thefr/
folder and translate all the files in it. Finally, add the language in thedocs/.vitepress/config.ts
file under thelocales
field.fr/
folder. Please chooseFrançais
in theLanguages
dropdown on the vitepress to see the results.README.md
file has been translated to french and saved here :docs/fr/README.md
.Feel free to give me a feedback.
Have a nice day.