docs: change type for unableAutoUnmount #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this change for `enableAutoUnmount` type makes it easier to understand.
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cexbrayat
reviewed
Feb 6, 2023
docs/api/index.md
Outdated
| @@ -1886,7 +1886,7 @@ function shallowMount(Component, options?: MountingOptions): VueWrapper | |||
| **Signature:** | |||
|
|
|||
| ```ts | |||
| enableAutoUnmount(hook: Function)); | |||
| enableAutoUnmount(hook: (callback: Function) => void)); | |||
There was a problem hiding this comment.
Maybe even hook: (callback: () => void) => void?
There was a problem hiding this comment.
I will update types, thx.
There was a problem hiding this comment.
To be coherent, maybe change the type here in the docs as well to be the same as the TS types?
lmiller1990
approved these changes
Feb 9, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this change for
enableAutoUnmounttype makes it easier to understand.If ok, i can change types in this PR too )