chore(mount): simplify mount operation #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
xanf
force-pushed
the
xanf-simplify-ref-access
branch
from
5254f7b to
a3a58e1
Compare
cexbrayat
approved these changes
Nov 3, 2022
xanf
force-pushed
the
xanf-simplify-ref-access
branch
from
a3a58e1 to
abdf994
Compare
* do not use ugly console.warn hack
xanf
force-pushed
the
xanf-simplify-ref-access
branch
from
abdf994 to
9d594e3
Compare
|
@cexbrayat that was fast, I've even was unable to push another version (full one), since my internet connection got flaky (I'm commuting between two cities via train 🚋 ) Now this one is a final state :) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this approach in main
@vuejs/corerepohttps://github.com/vuejs/core/blob/main/packages/runtime-core/__tests__/rendererTemplateRef.spec.ts#L23
I think this might be a good approach to simplify our codebase too!