chore: update to js-beautify v1.14.7 #1834
Conversation
The following commit in js-beautify introduced a breaking change for us, as custom element are now treated as inline elements beautifier/js-beautify@aa82eb9 This means a bunch of our tests, and snapshots of our users, break with this new version.
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I think we should talk with them to make it configurable. As it seems that all stubbed components are treat as custom elements |
|
@freakzlike I started a conversation beautifier/js-beautify#2113 |
until vuejs#1834 is resolved, we exclude js-beautify from renovate updates.
Until vuejs#1834 is resolved, we exclude js-beautify from renovate updates.
Until #1834 is resolved, we exclude js-beautify from renovate updates.
|
Hi all, sorry about the slow replies, was on leave for a while and not coding much. I agree we should try make it configurable. Snapshots are a bit unreliable (since implementation details like this can break them) but I'd really prefer to avoid breaking changes where possible. Looks like we've already got some movement in the JS Beautify repo, thanks @cexbrayat. |
|
For now, should we just lock |
|
@lmiller1990 We're locked on v1.14.6 (and I disabled Renovate for this package). I'll keep the PR around to have a reminder of this ongoing task, and hopefully we'll have feedback from the js-beautifier team soon (if not, then we'll close and stay on v1.14.6 forever...) |
|
Just curious, why |
We use it to format the output of |
|
Hello, is this advisory related to this PR and issue? Thank you |
|
@nathanaelytj Not directly. We can't update to the latest js-beautify version because of a breaking change. |
The PR introducing a new option to _not_ inline custom elements has been merged and released, allowing us to use the new version of js-beautify without introducing a breaking change. See vuejs#1834 for context
The PR introducing a new option to _not_ inline custom elements has been merged and released, allowing us to use the new version of js-beautify without introducing a breaking change. See vuejs#1834 for context
|
Superseeded by #2131 |
The PR introducing a new option to _not_ inline custom elements has been merged and released, allowing us to use the new version of js-beautify without introducing a breaking change. See #1834 for context
The following commit in js-beautify introduced a breaking change for us, as custom element are now treated as inline elements beautifier/js-beautify@aa82eb9
This means a bunch of our tests, and snapshots of our users, break with this new version.
What do you think we should do?