bugfix/unmounting-on-multi-root #182
Conversation
jw-foss
commented
Aug 20, 2020
•
jw-foss
commented
- Fix Unmount on multi-root component causes JSDOM error #181
- Fix the logic which causes unmounting fail when it's multi-root component
- Fix the logic which causes unmounting fail when it's multi-root component
|
I went through the mounting function and found out that the whole part of |
| const wrapper = mount(Component, { | ||
| props: {}, | ||
| global: { | ||
| config: { | ||
| errorHandler | ||
| } | ||
| } | ||
| } as any) // The type checking keeps complaning about unmatched type which might be a bug |
There was a problem hiding this comment.
Here I tried it with
mount(Component, {
global: {
config: ...
}
}Type system seems not agree with this syntax when custom component is mounting with global options
There was a problem hiding this comment.
Interesting, will deal with the types later, it's outside the scope of this ticket. Great job!
| const wrapper = mount(Component, { | ||
| props: {}, | ||
| global: { | ||
| config: { | ||
| errorHandler | ||
| } | ||
| } | ||
| } as any) // The type checking keeps complaning about unmatched type which might be a bug |
There was a problem hiding this comment.
Interesting, will deal with the types later, it's outside the scope of this ticket. Great job!
tests/unmount.spec.ts
Outdated
| const errorHandler = jest.fn() | ||
| const Component = defineComponent({ | ||
| template: ` | ||
| <div>${AXIOM}</div> |
There was a problem hiding this comment.
I don't think we need AXIOM, it doesn't really add much to the test. I am not sure who Rem is.
Can we just have <div /><div /> or something?
There was a problem hiding this comment.
Yep, sure. I'll remove the text later
Nice! Thanks for the quick response though |
