fix: Add props to stubs for built-in components #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
freakzlike
reviewed
Sep 13, 2022
freakzlike
approved these changes
Sep 15, 2022
|
@wolfgangwalther The build is failing. Ping me when you managed to fix it, and I'll merge the PR |
Signed-off-by: Wolfgang Walther <[email protected]>
@cexbrayat I don't really know typescript. While this should build now, I'm not sure whether that's a proper fix at all. |
|
I'll push an additional commit to slighly refactor. thanks @wolfgangwalther ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stubs for
<transition>,<transition-group>and<teleport>don't have any props defined, which currently makes it impossible to test for those to be set correctly.Took the props to add from https://vuejs.org/api/built-in-components.html.