feat: findComponent can find component inside a Suspense #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly updates the find implementation to: - check the suspense `subtree` if it is resolved - check the suspense `fallbackTree` otherwise A test has been added to check if we can find a component in both cases.
dobromir-hristov
approved these changes
Jul 30, 2020
lmiller1990
approved these changes
Aug 1, 2020
|
@dobromir-hristov not do I - maybe it was added after. Glad we have this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly updates the find implementation to:
subtreeif it is resolvedfallbackTreeotherwiseA test has been added to check if we can find a component in both cases.