Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type): add undefined type to attributes() for missing key #1398

Merged
merged 1 commit into from
Apr 5, 2022
Merged

fix(type): add undefined type to attributes() for missing key #1398

merged 1 commit into from
Apr 5, 2022

Conversation

freakzlike
Copy link
Collaborator

fix #1355

@netlify
Copy link

netlify bot commented Apr 4, 2022 •
edited
Loading

✅ Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 5aa02c1
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/624b2d937d281a00088298c8
😎 Deploy Preview https://deploy-preview-1398--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cexbrayat
cexbrayat approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lmiller1990
lmiller1990 approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@lmiller1990 lmiller1990 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

To save you a bit of time when making PRs, I'll add you to the repo. Also - any way to contact you (discord, email etc?). We have a Discord group for discussing release plans, I'd like to hit 2.0.0 soon, good to get a few more opinions/feedback.

@lmiller1990 lmiller1990 merged commit 5666ca4 into vuejs:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmiller1990 lmiller1990 lmiller1990 approved these changes

@cexbrayat cexbrayat cexbrayat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inaccurate Documentation/Function Signature for wrapper.attributes()
3 participants
@freakzlike @cexbrayat @lmiller1990