-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not include self when using findAll #1377
Conversation
✅ Deploy Preview for vue-test-utils-docs ready! 🔨 Explore the source changes: a9fd8b5 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-test-utils-docs/deploys/6238f3b344442300087dd839 😎 Browse the preview: https://deploy-preview-1377--vue-test-utils-docs.netlify.app |
cc @freakzlike @aethr WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👀 Looking on this right now |
@lmiller1990 This breaks the logic we've discussed in #1233 expect(wrapper.findAll('div').length).toBe(4) // actually returns 3 Let's keep this discussion in #1233 (comment) to keep all the context in one place |
@xanf pushed a commit to fix that. |
@lmiller1990 looking |
@lmiller1990 while reviewing your PR I've found another failing case - https://github.com/vuejs/test-utils/pull/1392/files#diff-9835123bc80f420fd7ebbcc25a72c73e7f2c8934bac14a9a3bbe6e1dca3569f7R356 And I believe I've figured more elegant approach in #1392 /cc @cexbrayat |
resolves #1233
Seems too easy 🤔