test: Add tests for shallowMount issue with dynamic components #1312
Conversation
|
✔️ Deploy Preview for vue-test-utils-docs ready! 🔨 Explore the source changes: eeaaf1e 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-test-utils-docs/deploys/620cd8afa772250007adff95 😎 Browse the preview: https://deploy-preview-1312--vue-test-utils-docs.netlify.app |
| @@ -0,0 +1,19 @@ | |||
| <template> | |||
| <component :is="Hello" /> | |||
There was a problem hiding this comment.
shouldn't that use computedProperty?
There was a problem hiding this comment.
@cexbrayat This is what I meant when I added the note. It does not matter whether you use the computed property, its name is still what shallowMount will give to component. That's how weird this bug is.
There was a problem hiding this comment.
I'll add a third test, one that will pass, to better outline the issue.
phobetron
force-pushed
the
test/1277_adding-failing-tests-for-dynamic-component-shallow-mount-issue
branch
from
66604e9 to
254bd9e
Compare
phobetron
force-pushed
the
test/1277_adding-failing-tests-for-dynamic-component-shallow-mount-issue
branch
from
254bd9e to
89fe6a7
Compare
|
Hmm strange indeed, thanks for the repo 👍 If you feel adventurous, you can try to inspect what's going on when the tests run, and you may be able to fix the issue: we would be very happy to accept the PR! |
|
@cexbrayat The issue was exactly where @freakzlike had suggested. My fix is to ensure |
|
@phobetron can you fix the linting errors? |
phobetron
force-pushed
the
test/1277_adding-failing-tests-for-dynamic-component-shallow-mount-issue
branch
from
416dd8d to
710d68f
Compare
|
@lmiller1990 Sorry about that! I think my local has a different default line length. Should be fixed now. |
|
@phobetron : the CI is failing because |
|
@cexbrayat That makes sense. I've reduced the test code to the minimum necessary to cover the error case. Should pass everything now 😅 |
phobetron
force-pushed
the
test/1277_adding-failing-tests-for-dynamic-component-shallow-mount-issue
branch
from
9e5563d to
eeaaf1e
Compare
|
@cexbrayat Sorry, decided to make another minor style adjustment. |
|
Looks great, thank you for taking the time to investigate and fix this, we really appreciate it! |
phobetron
deleted the
test/1277_adding-failing-tests-for-dynamic-component-shallow-mount-issue
branch
This PR adds a minimal set of tests to describe issue #1277, which regards how dynamic components, when shallow mounted, are stubbed with the name of a computed property that returns a component's name instead of the component itself.
The test component outlines the most extreme error case: a computed property does not need to be referenced in order to trigger the issue, it merely needs to both exist and return the component that is directly referenced.
This PR now also implements a possible simple fix for the issue.
cc: @cexbrayat