Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: doc website search bar not work #1512

Closed
arnauddoub opened this issue May 19, 2022 · 9 comments · Fixed by #1636
Closed

Bug: doc website search bar not work #1512

arnauddoub opened this issue May 19, 2022 · 9 comments · Fixed by #1636
Labels
bug Something isn't working

Comments

@arnauddoub
Copy link

Describe the bug
On the site test-utils.vuejs.org when I open the search bar I get an error
POST https://undefined-dsn.algolia.net/1/indexes/*/queries?x-algolia-agent=Algolia%20for%20JavaScript%20(4.8.5)%3B%20Browser%20(lite)%3B%20docsearch%20(3.0.0)%3B%20docsearch-react%20(3.0.0)%3B%20docsearch.js%20(3.0.0)&x-algolia-api-key=ee1b8516c9e5a5be9b6c25684eafc42f&x-algolia-application-id=undefined net::ERR_NAME_NOT_RESOLVED

To Reproduce
I go to website test-utils.vuejs.org, i click on the search bar, i fill input and nothing happens.

Expected behavior
I want to use the search bar.

Related information:

  • Website doc production

Additional context
Screenshot 2022-05-19 at 10 20 03

@arnauddoub arnauddoub added the bug Something isn't working label May 19, 2022
@cexbrayat
Copy link
Member

Thanks for the report, we'll look into it 👍

@lmiller1990
Copy link
Member

Algolia bug? I've not worked with the Algolia integration before.

Looks like the application id is undefined

x-algolia-api-key=ee1b8516c9e5a5be9b6c25684eafc42f&x-algolia-application-id=undefined

Not sure what's going on. I am also not sure who set up Algolia or how we can configure it, maybe @afontcu?

@afontcu
Copy link
Member

afontcu commented Jun 2, 2022

hey! yeah I set it up a while ago, and I'd say it worked as expected. Probably something went south during the site transition for vue 2 -> vue 3. I remember we needed to define some tags to split the V1 docs and the V2 ones, but now that might work different as domains are different as well.

For instance, current config is probably aiming at the old setup (notice the tags:next filters). I recall contacting to algolia open source support team, they were really helpful to set up the appropriate config

@luckylooke
Copy link

Please, searching docs is quite important feature of libraries, thanks 🙏 🙏 🙏

@lmiller1990
Copy link
Member

lmiller1990 commented Jun 23, 2022

If someone wants to pick this up that would be great - you don't need to a member of this repo/org to reach out to Algolia and make this request (if this is even necessary, maybe they just changed the API and we need to reconfigure something here?)

I am swamped in 50+ notifications a day with all the projects I work on and won't be able to look into this at this point in time.

Some help from anyone reading this would be greatly appreciated!

An alternative would be using the default Vitepress search instead of Algolia, I don't fin the Algolia search to be that much better, and we'd reduce our reliance on a third party.

@okxiaoliang4
Copy link
Contributor

okxiaoliang4 commented Jun 30, 2022

@lmiller1990 Hi, I can help to fix this.
but need you invite me to the team :)
my account is: [email protected]

@lmiller1990
Copy link
Member

@okxiaoliang4 what's the fix? Can you just send us a PR?

Due to the nature of this project (millions of downloads / week) we tend to not add people to the team unless there's a compelling reason to do so (many contributions, triaging issues, etc).

@okxiaoliang4
Copy link
Contributor

I think the appId is missing, but I can't send pr because I can't get the appId from Algolia 😀 @lmiller1990

@lmiller1990
Copy link
Member

lmiller1990 commented Jul 1, 2022

Where is the appId? How do we get it? I don't know how the Algolia search is configured.

I don't have access to anything you don't. The entire repo is completely OSS. Let me know what you need me to do 👍

Based on this comment #1512 (comment) it looks like someone (you, if you like) just needs to email the Algolia OSS team and explain the situation, link to the repo, and they'll be able to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants