Skip to content

Commit

Permalink
fix: properly declare optional peer deps
Browse files Browse the repository at this point in the history
We used `optionalDependencies` in #1958 but I think the proper way is to use `peerDependenciesMeta`.
This fixes the current issue where pnpm installs compiler-dom and server-renderer in v3.2.47,
despite v3.3.1 being available.
  • Loading branch information
cexbrayat committed May 11, 2023
1 parent 41b772e commit 0a07785
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 75 deletions.
12 changes: 8 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,13 @@
"@vue/server-renderer": "^3.0.1",
"vue": "^3.0.1"
},
"optionalDependencies": {
"@vue/compiler-dom": "^3.0.1",
"@vue/server-renderer": "^3.0.1"
"peerDependenciesMeta": {
"@vue/compiler-dom": {
"optional": true
},
"@vue/server-renderer": {
"optional": true
}
},
"author": {
"name": "Lachlan Miller",
Expand Down Expand Up @@ -121,4 +125,4 @@
]
}
}
}
}
102 changes: 31 additions & 71 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0a07785

Please sign in to comment.