fix: keep optional params coming from a parent record

[chuyuandu]

resolve TODO: only keep optional params coming from a parent record

[netlify]

✅ Deploy Preview for vue-router ready!

Name	Link
🔨 Latest commit	8fa3574
🔍 Latest deploy log	https://app.netlify.com/sites/vue-router/deploys/6548c8868c7ec300088b7137
😎 Deploy Preview	https://deploy-preview-2031--vue-router.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov-commenter]

Codecov Report

Merging #2031 (0d414e1) into main (b6d12ed) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #2031      +/-   ##
==========================================
+ Coverage   90.77%   90.79%   +0.02%     
==========================================
  Files          24       24              
  Lines        1116     1119       +3     
  Branches      348      349       +1     
==========================================
+ Hits         1013     1016       +3     
  Misses         63       63              
  Partials       40       40              

Files	Coverage Δ
packages/router/src/matcher/index.ts	98.78% <100.00%> (+0.02%)	⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[posva]

Thanks!

• It should also go for ancestors, not just direct parents parents have all ancestors
• It should have tests about how params with matching names but coming from different routes are discarded

But I'm actually unsure if this is the desired behavior. Currently, matching params are silently passed around and people might find that useful. I wonder if making this behavior stricter will be better in the long term

[posva]

This could be done once at the end

[chuyuandu]

1. A direct parent's keys contains all optional params, includes ancestors
2. I'll open a new PR to improve the code if the behavior it is necessary, absolutely i think this is better to keep the optional params from parent record.

{
    path: '/:type?/root',
    children: [
    {
        path: 'path_a',
        name: 'a',
    },
    {
        path: 'path_b',
        name: 'b',
    }
  ]
}

// current path:   '/optionType/root/path_a'

resolve({
    name: 'b'
});

I think /optionType/root/path_b is better than /root/path_b in this case

[posva]

I guess o forgot how I wrote my own code 😂

[chuyuandu]

I suggest to keep optional params coming from a parent record, that is really useful

[chuyuandu]

@posva hey, i have improved the code and add unit tests

[posva]

thanks! I will check later on this year