Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for old versions of ESLint and Node.js #2669

Merged
merged 11 commits into from
Jan 30, 2025
Merged

Drop support for old versions of ESLint and Node.js #2669

merged 11 commits into from
Jan 30, 2025
+28 −234

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Jan 28, 2025 •
edited by FloEdelmann
Loading

Fixes #1991

FloEdelmann
FloEdelmann reviewed Jan 29, 2025
View reviewed changes
@FloEdelmann FloEdelmann changed the title Drop support old eslint and node Drop support for old versions of ESLint and Node.js Jan 29, 2025
@FloEdelmann FloEdelmann mentioned this pull request Dec 19, 2024
Open
FloEdelmann
FloEdelmann reviewed Jan 29, 2025
View reviewed changes
@FloEdelmann
Copy link
Member

@ota-meshi I rebased v10 onto master and then I rebased drop-old onto v10 so everything is clean again. So please run git pull --rebase or git reset --hard origin/drop-old locally.

FloEdelmann
FloEdelmann approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 🙂

@FloEdelmann FloEdelmann merged commit 33f3137 into v10 Jan 30, 2025
7 checks passed
@FloEdelmann FloEdelmann deleted the drop-old branch January 30, 2025 09:52
@FloEdelmann FloEdelmann mentioned this pull request Jan 30, 2025
Closed
FloEdelmann pushed a commit that referenced this pull request Feb 12, 2025
@ota-meshi @FloEdelmann
Drop support for old versions of ESLint and Node.js (#2669)
63dc3b8
FloEdelmann pushed a commit that referenced this pull request Feb 12, 2025
@ota-meshi @FloEdelmann
Drop support for old versions of ESLint and Node.js (#2669)
7b50d15
waynzh pushed a commit that referenced this pull request Feb 20, 2025
@ota-meshi @waynzh
Drop support for old versions of ESLint and Node.js (#2669)
69b09db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
breaking change semver-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ota-meshi @FloEdelmann