Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking for script setup in vue/require-typed-ref #2427

Merged
merged 3 commits into from
May 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions lib/rules/require-typed-ref.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,23 @@ module.exports = {
return {}
}

const scriptSetup = utils.getScriptSetupElement(context)
if (
scriptSetup &&
!utils.hasAttribute(scriptSetup, 'lang', 'ts') &&
!utils.hasAttribute(scriptSetup, 'lang', 'typescript')
) {
return {}
if (utils.isVueFile(filename)) {
const sourceCode = context.getSourceCode()
const documentFragment =
sourceCode.parserServices.getDocumentFragment &&
sourceCode.parserServices.getDocumentFragment()
if (!documentFragment) {
return {}
}
const scripts = documentFragment.children.filter(
/** @returns {element is VElement} */
(element) => utils.isVElement(element) && element.name === 'script'
)
if (
scripts.every((script) => !utils.hasAttribute(script, 'lang', 'ts'))
) {
return {}
}
}

const defines = iterateDefineRefs(
Expand Down
38 changes: 38 additions & 0 deletions tests/lib/rules/require-typed-ref.js
FloEdelmann marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,20 @@ tester.run('require-typed-ref', rule, {
`,
languageOptions: { parser: require('vue-eslint-parser') }
},
{
filename: 'test.vue',
code: `
<script>
import { ref } from 'vue'
export default {
setup() {
const count = ref()
}
}
</script>
`,
languageOptions: { parser: require('vue-eslint-parser') }
},
{
filename: 'test.js',
code: `
Expand Down Expand Up @@ -217,6 +231,30 @@ tester.run('require-typed-ref', rule, {
],
languageOptions: { parser: require('vue-eslint-parser') }
},
{
filename: 'test.vue',
code: `
<script lang="ts">
import { ref } from 'vue'
export default {
setup() {
const count = ref()
}
}
</script>
}
`,
errors: [
{
messageId: 'noType',
line: 6,
column: 29,
endLine: 6,
endColumn: 34
}
],
languageOptions: { parser: require('vue-eslint-parser') }
},
{
filename: 'test.ts',
code: `
Expand Down
Loading