Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(order-in-components): add side effects suggestions #2423

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Mar 11, 2024

closes #2418

@waynzh waynzh marked this pull request as draft March 11, 2024 12:26
@waynzh waynzh marked this pull request as ready for review March 11, 2024 13:35
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I only have one small change request.

lib/rules/order-in-components.js Outdated Show resolved Hide resolved
@waynzh waynzh requested a review from FloEdelmann March 11, 2024 14:10
@FloEdelmann FloEdelmann requested a review from ota-meshi March 11, 2024 14:19
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit e2dc84b into vuejs:master Mar 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer suggestions in vue/order-in-components when autofix is not available
3 participants