Skip to content

Commit

Permalink
Revert "feat: add dedupe step for all projects using pnpm or npm"
Browse files Browse the repository at this point in the history
This reverts commit 5a65c65.

Because somehow pinia is not working with pnpm dedupe
  • Loading branch information
haoqunjiang committed Dec 13, 2023
1 parent 1a4abe2 commit 6356adf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions tests/language-tools.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export async function test(options: RunOptions) {
...options,
repo: 'vuejs/language-tools',
branch: 'master',
beforeBuild: 'pnpm dedupe',
build: 'build',
test: 'test',
})
Expand Down
3 changes: 0 additions & 3 deletions utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -575,13 +575,10 @@ export async function applyPackageOverrides(
// use of `ni` command here could cause lockfile violation errors so fall back to native commands that avoid these
if (pm === 'pnpm') {
await $`pnpm install --no-frozen-lockfile --no-strict-peer-dependencies --registry ${REGISTRY_ADDRESS}`
await $`pnpm dedupe`
} else if (pm === 'yarn') {
await $`yarn install --registry ${REGISTRY_ADDRESS}`
// TODO: run `npx yarn-deduplicate` for Yarn v1 and `yarn dedupe` for Yarn >= v2
} else if (pm === 'npm') {
await $`npm install --registry ${REGISTRY_ADDRESS}`
await $`npm dedupe`
}
}

Expand Down

0 comments on commit 6356adf

Please sign in to comment.