Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR about hotkeys from here
![image](https://github.com/vuejs/devtools/assets/41228762/1cac1b0b-50d6-48a5-8384-2f477c832768)
On Mac "option" key modifies the resulted
event.key
value (s
becomesß
) that's why checkevent.key === 's'
doesn't work.According to mdn's KeyboardEvent: code article we can't fix the bug with
event.code === 'KeyS'
because on different keyboard layouts symbol will be different.So I just added the resulting keys to the whitelist.
Additional context
There is another old PR but with a different fix
https://github.com/vuejs/devtools/pull/1993
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).