fix(types): Add Missing Methods & Props to "./packages/shell-electron/types" #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice |
Akryum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that the
initmethod exported out ofpackages\shell-electron\index.jswas missing from the type file. This pull request fixes that.Additionally the type information for the
connectmethod was missing the{ io, showToast, app}object as an optional prop. This pull request adds it as a parameter named "options", where the option properties are defined in theConnectOptionsinterface.You'll also notice that this pull request adds
vueas a dev dependency so that theVuetype can included in the type definitionsBefore
Before this change Typescript show type errors
After
Typescript errors are gone
