Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snapshot generation #383

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix: snapshot generation #383

merged 1 commit into from
Nov 24, 2023

Conversation

cexbrayat
Copy link
Member

It looks like the addition of nightwatch broke the snapshot generation, as nightwatch was added to the deny list (correctly), but it means that the only combinations that are filtered are the ones with the 3 e2e test libraries at the same time.

We also need to filter out the combination of Cypress with Playwright, Cypress with Nightwatch, and Playwright with Nightwatch.

See https://github.com/vuejs/create-vue-templates/ that currently includes cypress-playwright for example.

This commit updates the script to remove all generated combinations, and to generate only the proper ones.

It looks like the addition of nightwatch broke the snapshot generation, as `nightwatch` was added to the deny list (correctly),
but it means that the _only_ combinations that are filtered are the ones with the 3 e2e test libraries at the same time.

We also need to filter out the combination of Cypress with Playwright, Cypress with Nightwatch, and Playwright with Nightwatch.

See https://github.com/vuejs/create-vue-templates/ that currently includes cypress-playwright for example.

This commit updates the script to remove all generated combinations, and to generate only the proper ones.
@cexbrayat
Copy link
Member Author

@sodatea This is a first step to support Vite 5: currently ,the pnpm test script is failing because the playground includes projects that can't work.
Then we need to fix the *-nightwatch projects. They aren't tested on CI, and they don't work out-of-the-box. I'll see what I can do when this PR lands.

@haoqunjiang haoqunjiang merged commit 5ba8f64 into vuejs:main Nov 24, 2023
101 checks passed
@haoqunjiang
Copy link
Member

Then we need to fix the *-nightwatch projects. They aren't tested on CI, and they don't work out-of-the-box. I'll see what I can do when this PR lands.

GitHub Actions limits the maximum number of jobs a matrix can generate, so I had to leave out some of the tests.
Maybe we can squash some small jobs into one and parallelize the rest; hopefully the CI time won't increase too much.

@cexbrayat
Copy link
Member Author

Thanks for the review. I'll fix the local test script first to make sure Nightwatch projects are OK, then we can take a look at the CI workflow 👍

@cexbrayat cexbrayat deleted the fix/snapshots branch November 24, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants