Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(compiler-core): extract forAliasRE regex #9568

Merged
merged 1 commit into from
Nov 10, 2023
Merged

refactor(compiler-core): extract forAliasRE regex #9568

merged 1 commit into from
Nov 10, 2023

Conversation

jh-leong
Copy link
Member

@jh-leong jh-leong commented Nov 8, 2023

This PR removes duplicated forAliasRE regex.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.4 kB 32.9 kB 29.6 kB
vue.global.prod.js 132 kB 49.6 kB (+8 B) 44.5 kB (+11 B)

Usages

Name Size Gzip Brotli
createApp 48 kB 18.9 kB 17.3 kB
createSSRApp 51.1 kB 20.1 kB 18.4 kB
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@sxzz sxzz changed the title chore(compiler-core): extract forAliasRE regex refactor(compiler-core): extract forAliasRE regex Nov 8, 2023
@sxzz sxzz added ready to merge The PR is ready to be merged. scope: compiler easy to merge labels Nov 8, 2023
@yyx990803 yyx990803 merged commit d5fd343 into vuejs:main Nov 10, 2023
11 checks passed
@jh-leong jh-leong deleted the chore/extract_forAliasRE branch November 11, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
easy to merge ready to merge The PR is ready to be merged. scope: compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jh-leong @sxzz @yyx990803